This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
no conflict on policy insert, add users allows [] array for consistency #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mihaidma, this PR ignores conflicts on insert policy (note: if updates are performed on policy instances, we will throw the conflict error)
this PR also changed validation so that ids in team/user arrays can be empty for consistency to be like policies as per slack channel discussion, if there are entries it also enforces the id validation.
I'm not sure it makes sense to allow empty on PUT, we can add to all if necessary by putting min for each payload array...